sunyuhan1998 commented on code in PR #11058:
URL: https://github.com/apache/gravitino/pull/11058#discussion_r3234291022
##########
clients/client-python/gravitino/client/gravitino_metalake.py:
##########
@@ -767,3 +780,60 @@ def set_owner(
)
set_resp = SetResponse.from_json(response.body, infer_missing=True)
set_resp.validate()
+
+ ####################
+ # User operations
+ ####################
+
+ def add_user(self, user: str) -> User:
+ """Add a user to this metalake."""
+ Precondition.check_string_not_empty(user, "user name must not be null
or empty")
+ req = UserAddRequest(user)
Review Comment:
I considered this suggestion but decided to keep user as the parameter name
for consistency with the Java SDK, which uses String user throughout
(GravitinoClient.addUser(String user), GravitinoMetalake.addUser(String user)).
Instead, I've expanded the docstrings to clarify: user: The name of the user. —
matching the Java SDK's @param user The name of the User. convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
