mchades commented on code in PR #10998: URL: https://github.com/apache/gravitino/pull/10998#discussion_r3252858092
########## catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/HiveViewCatalogOperations.java: ########## @@ -0,0 +1,471 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.catalog.hive; + +import static org.apache.gravitino.catalog.hive.HiveConstants.COMMENT; +import static org.apache.gravitino.catalog.hive.HiveConstants.HIVE_FILTER_FIELD_PARAMS; +import static org.apache.gravitino.catalog.hive.HiveConstants.TABLE_TYPE; + +import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableMap; +import com.google.common.collect.Maps; +import java.time.Instant; +import java.util.List; +import java.util.Map; +import java.util.function.Predicate; +import java.util.function.Supplier; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.Namespace; +import org.apache.gravitino.exceptions.NoSuchSchemaException; +import org.apache.gravitino.exceptions.NoSuchViewException; +import org.apache.gravitino.exceptions.ViewAlreadyExistsException; +import org.apache.gravitino.hive.CachedClientPool; +import org.apache.gravitino.hive.HiveTable; +import org.apache.gravitino.meta.AuditInfo; +import org.apache.gravitino.rel.Column; +import org.apache.gravitino.rel.Dialects; +import org.apache.gravitino.rel.Representation; +import org.apache.gravitino.rel.SQLRepresentation; +import org.apache.gravitino.rel.View; +import org.apache.gravitino.rel.ViewCatalog; +import org.apache.gravitino.rel.ViewChange; +import org.apache.gravitino.utils.PrincipalUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +class HiveViewCatalogOperations implements ViewCatalog { + private static final Logger LOG = LoggerFactory.getLogger(HiveViewCatalogOperations.class); + private static final short MAX_TABLES = -1; + + private final Supplier<CachedClientPool> clientPoolSupplier; + private final Supplier<String> catalogNameSupplier; + private final Predicate<NameIdentifier> schemaExistsChecker; + + HiveViewCatalogOperations( + Supplier<CachedClientPool> clientPoolSupplier, + Supplier<String> catalogNameSupplier, + Predicate<NameIdentifier> schemaExistsChecker) { + this.clientPoolSupplier = clientPoolSupplier; + this.catalogNameSupplier = catalogNameSupplier; + this.schemaExistsChecker = schemaExistsChecker; + } + + @Override + public NameIdentifier[] listViews(Namespace namespace) throws NoSuchSchemaException { + NameIdentifier schemaIdent = NameIdentifier.of(namespace.levels()); + if (!schemaExistsChecker.test(schemaIdent)) { + throw new NoSuchSchemaException("Schema %s does not exist", namespace); + } + try { + String viewFilter = + String.format("%stableType like \"VIRTUAL_VIEW\"", HIVE_FILTER_FIELD_PARAMS); + List<String> views = + clientPool() + .run( + c -> + c.listTableNamesByFilter( + catalogName(), schemaIdent.name(), viewFilter, MAX_TABLES)); + return views.stream() + .map(name -> NameIdentifier.of(namespace, name)) + .toArray(NameIdentifier[]::new); + } catch (InterruptedException e) { + throw new RuntimeException("Failed to list Hive views in " + namespace, e); + } + } + + @Override + public View loadView(NameIdentifier ident) throws NoSuchViewException { + return loadHiveView(ident); + } + + @Override + public View createView( + NameIdentifier ident, + String comment, + Column[] columns, + Representation[] representations, + String defaultCatalog, + String defaultSchema, + Map<String, String> properties) + throws NoSuchSchemaException, ViewAlreadyExistsException { + NameIdentifier schemaIdent = NameIdentifier.of(ident.namespace().levels()); + if (!schemaExistsChecker.test(schemaIdent)) { + throw new NoSuchSchemaException("Schema %s does not exist", schemaIdent); + } + SQLRepresentation sqlRepresentation = + validateSQLRepresentation(representations, defaultCatalog, defaultSchema, ident); + + try { + Map<String, String> params = + Maps.newHashMap(properties == null ? ImmutableMap.of() : properties); + params.put(TABLE_TYPE, TableType.VIRTUAL_VIEW.name()); + String viewOriginalText = toHmsViewOriginalText(sqlRepresentation, ident); + + HiveTable hiveTable = + HiveTable.builder() + .withName(ident.name()) + .withComment(comment) + .withColumns(copyColumns(columns)) + .withProperties(params) + .withAuditInfo( + AuditInfo.builder() + .withCreator(PrincipalUtils.getCurrentUserName()) + .withCreateTime(Instant.now()) + .build()) + .withCatalogName(catalogName()) + .withDatabaseName(schemaIdent.name()) + .withViewOriginalText(viewOriginalText) + .build(); + + clientPool() + .run( + c -> { + c.createTable(hiveTable); + return null; + }); + + LOG.info("Created Hive view {} in Hive Metastore", ident.name()); + return toHiveView( + ident, + hiveTable.comment(), + hiveTable.properties(), + hiveTable.viewOriginalText(), + hiveTable.columns(), + hiveTable.auditInfo()); + } catch (Exception e) { + if (isAlreadyExistsError(e)) { + throw new ViewAlreadyExistsException("View %s already exists in Hive Metastore", ident); + } + throw new RuntimeException("Failed to create Hive view " + ident, e); + } + } + + @Override + public View alterView(NameIdentifier ident, ViewChange... changes) + throws NoSuchViewException, ViewAlreadyExistsException { + NameIdentifier schemaIdent = NameIdentifier.of(ident.namespace().levels()); + + try { + HiveTable currentHiveTable = + clientPool().run(c -> c.getTable(catalogName(), schemaIdent.name(), ident.name())); + if (!TableType.VIRTUAL_VIEW + .name() + .equalsIgnoreCase(currentHiveTable.properties().get(TABLE_TYPE))) { + throw new NoSuchViewException("No view named %s (it is a table, not a view)", ident.name()); + } + + String newViewName = currentHiveTable.name(); + String updatedViewOriginalText = currentHiveTable.viewOriginalText(); + Map<String, String> updatedProperties = Maps.newHashMap(currentHiveTable.properties()); + Column[] updatedColumns = copyColumns(currentHiveTable.columns()); + String updatedComment = currentHiveTable.comment(); + updatedProperties.remove(COMMENT); + + for (ViewChange change : changes) { + if (change instanceof ViewChange.RenameView) { + String renameTarget = ((ViewChange.RenameView) change).getNewName(); + NameIdentifier targetIdent = NameIdentifier.of(ident.namespace(), renameTarget); + if (viewExists(targetIdent)) { + throw new ViewAlreadyExistsException( + "View %s already exists in Hive Metastore", targetIdent); + } + newViewName = renameTarget; + } else if (change instanceof ViewChange.SetProperty) { + ViewChange.SetProperty sp = (ViewChange.SetProperty) change; + if (COMMENT.equals(sp.getProperty())) { + updatedComment = sp.getValue(); + } else { + updatedProperties.put(sp.getProperty(), sp.getValue()); + } + } else if (change instanceof ViewChange.RemoveProperty) { + String property = ((ViewChange.RemoveProperty) change).getProperty(); + if (COMMENT.equals(property)) { + updatedComment = null; + } else { + updatedProperties.remove(property); + } + } else if (change instanceof ViewChange.ReplaceView) { + ViewChange.ReplaceView replace = (ViewChange.ReplaceView) change; + SQLRepresentation sqlRepresentation = + validateSQLRepresentation( + replace.getRepresentations(), + replace.getDefaultCatalog(), + replace.getDefaultSchema(), + ident); + updatedColumns = copyColumns(replace.getColumns()); + updatedComment = replace.getComment(); + updatedViewOriginalText = toHmsViewOriginalText(sqlRepresentation, ident); + } else { + throw new IllegalArgumentException( + "Unsupported view change type: " + change.getClass().getSimpleName()); + } + } + + HiveTable updatedHiveTable = + buildAlteredHiveView( + currentHiveTable, + schemaIdent, + newViewName, + updatedComment, + updatedProperties, + updatedColumns, + updatedViewOriginalText); + + final String originalName = ident.name(); + clientPool() + .run( + c -> { + c.alterTable(catalogName(), schemaIdent.name(), originalName, updatedHiveTable); + return null; + }); + + LOG.info("Altered Hive view {} (now {})", ident.name(), newViewName); + NameIdentifier updatedIdent = NameIdentifier.of(ident.namespace(), newViewName); + return toHiveView( + updatedIdent, + updatedHiveTable.comment(), + updatedHiveTable.properties(), + updatedHiveTable.viewOriginalText(), + updatedHiveTable.columns(), + updatedHiveTable.auditInfo()); + } catch (NoSuchViewException | ViewAlreadyExistsException | IllegalArgumentException e) { + throw e; + } catch (UnsupportedOperationException e) { + throw e; + } catch (Exception e) { + if (isAlreadyExistsError(e)) { + throw new ViewAlreadyExistsException( + "View %s already exists in Hive Metastore", + NameIdentifier.of(ident.namespace(), extractRenameTargetName(ident.name(), changes))); + } + throw new RuntimeException("Failed to alter Hive view " + ident, e); + } + } + + private HiveTable buildAlteredHiveView( + HiveTable currentHiveTable, + NameIdentifier schemaIdent, + String viewName, + String comment, + Map<String, String> properties, + Column[] columns, + String viewOriginalText) { + return HiveTable.builder() + .withName(viewName) + .withComment(comment) + .withColumns(copyColumns(columns)) Review Comment: We keep the column copy intentionally to avoid external array mutations affecting the internal view/table state during create/alter flows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
