diqiu50 commented on code in PR #11074:
URL: https://github.com/apache/gravitino/pull/11074#discussion_r3257048622
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/SchemaMetaService.java:
##########
@@ -623,4 +522,39 @@ private static long nextIdForNestedAncestor() {
}
return generator.nextId();
}
+
+ private static SchemaPO physicalToLogicalSchemaPO(SchemaPO po) {
+ String name = po.getSchemaName();
+ if (name == null ||
!name.contains(HierarchicalSchemaUtil.physicalSeparator())) {
+ return po;
+ }
+ return copySchemaPOWithName(
+ po,
+ HierarchicalSchemaUtil.physicalToLogical(name,
HierarchicalSchemaUtil.schemaSeparator()));
+ }
+
+ private static SchemaPO logicalToPhysicalSchemaPO(SchemaPO po) {
+ String name = po.getSchemaName();
+ if (name == null ||
!name.contains(HierarchicalSchemaUtil.schemaSeparator())) {
+ return po;
+ }
+ return copySchemaPOWithName(
+ po,
+ HierarchicalSchemaUtil.logicalToPhysical(name,
HierarchicalSchemaUtil.schemaSeparator()));
+ }
+
+ private static SchemaPO copySchemaPOWithName(SchemaPO po, String name) {
Review Comment:
Why don't we changed po instead of copy it
##########
core/src/main/java/org/apache/gravitino/storage/relational/RelationalEntityStore.java:
##########
@@ -327,6 +327,26 @@ public void insertRelation(
cache.invalidate(dstIdentifier, dstType, relType);
}
+ @Override
+ public void batchInsertRelations(
+ Type relType,
+ List<NameIdentifier> srcIdentifiers,
+ Entity.EntityType srcType,
+ NameIdentifier dstIdentifier,
+ Entity.EntityType dstType,
+ boolean override)
+ throws IOException {
+ if (srcIdentifiers == null || srcIdentifiers.isEmpty()) {
+ return;
+ }
+ backend.batchInsertRelations(
+ relType, srcIdentifiers, srcType, dstIdentifier, dstType, override);
+ for (NameIdentifier ident : srcIdentifiers) {
+ cache.invalidate(ident, srcType, relType);
+ }
+ cache.invalidate(dstIdentifier, dstType, relType);
Review Comment:
Cache invalidation after the DB operation is appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
