mchades commented on code in PR #10998:
URL: https://github.com/apache/gravitino/pull/10998#discussion_r3263408330
##########
catalogs/hive-metastore-common/src/main/java/org/apache/gravitino/hive/converter/HiveTableConverter.java:
##########
@@ -135,13 +150,29 @@ public static org.apache.hadoop.hive.metastore.api.Table
toHiveTable(HiveTable h
hiveTable.properties().getOrDefault(TABLE_TYPE,
String.valueOf(TableType.MANAGED_TABLE));
table.setTableType(tableType.toUpperCase());
- List<FieldSchema> partitionFields =
- hiveTable.partitionFieldNames().stream()
- .map(fieldName -> buildPartitionKeyField(fieldName, hiveTable))
- .collect(Collectors.toList());
- table.setSd(buildStorageDescriptor(hiveTable, partitionFields));
+ if (TableType.VIRTUAL_VIEW.name().equalsIgnoreCase(tableType)) {
Review Comment:
I didn't see any other places that need to reuse this function. Could you
point it out specifically?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
