Copilot commented on code in PR #11129:
URL: https://github.com/apache/gravitino/pull/11129#discussion_r3264909734


##########
docs/lakehouse-paimon-catalog.md:
##########
@@ -232,6 +232,20 @@ Bucket settings are defined via Gravitino table 
distribution (HASH strategy). Th
 
 Please refer to [Manage Relational Metadata Using 
Gravitino](./manage-relational-metadata-using-gravitino.md#table-operations) 
for more details.
 
+## View
+
+### View capabilities
+
+- Supports list, create, load, alter, and drop for views stored in the Paimon 
catalog.
+- Each view must include exactly one SQL representation with dialect `query`, 
which serves as the canonical view definition.
+- Additional dialect-specific SQL representations (for example, `spark` or 
`trino`) can be provided alongside the required `query` representation.

Review Comment:
   The Paimon view capability bullets are internally inconsistent: one bullet 
says each view must include exactly one SQL representation with dialect 
`query`, but the next bullet says additional dialect-specific representations 
can be provided. Reword to clarify whether multiple representations are allowed 
(e.g., "must include exactly one `query` representation" while allowing others) 
to avoid confusing users.
   



##########
docs/manage-view-metadata-using-gravitino.md:
##########
@@ -0,0 +1,288 @@
+---
+title: "Manage view metadata using Apache Gravitino"
+slug: /manage-view-metadata-using-gravitino
+date: 2026-5-17
+keyword: Gravitino view metadata manage
+license: This software is licensed under the Apache License version 2.
+---
+
+import Tabs from '@theme/Tabs';
+import TabItem from '@theme/TabItem';
+
+This page introduces how to manage view metadata by Apache Gravitino. A view 
stores a logical
+query definition rather than physical data. Through Gravitino, you can create, 
load, alter,
+drop, and list views in supported catalogs via unified REST APIs or the Java 
client.
+
+When a catalog implements view management, Gravitino operates on the 
provider's native view
+metadata rather than a separate Gravitino-only view type. View capabilities 
are implemented by
+each catalog provider and may differ in operation coverage and SQL dialect 
behavior. For detailed
+support, see:
+
+- [Hive view capabilities](./apache-hive-catalog.md#view-capabilities)
+- [Iceberg view capabilities](./lakehouse-iceberg-catalog.md#view-capabilities)
+- [Paimon view capabilities](./lakehouse-paimon-catalog.md#view-capabilities)
+
+Unlike tables, views define query output and one or more representations, but 
do not manage
+partitions, sort orders, indexes, or physical storage locations. The 
representation model is
+extensible, but currently only SQL representations are supported.
+
+To use view management, please make sure that:
+
+ - Gravitino server has started, and the host and port is 
[http://localhost:8090](http://localhost:8090).

Review Comment:
   In the prerequisites list, the subject is plural: "the host and port". The 
sentence currently uses singular verb ("is"), which is grammatically incorrect 
and reads awkwardly in user docs. Update it to use a plural verb (or rephrase 
as a single endpoint URL).
   



##########
docs/manage-relational-metadata-using-gravitino.md:
##########
@@ -10,9 +10,11 @@ import Tabs from '@theme/Tabs';
 import TabItem from '@theme/TabItem';
 
 This page introduces how to manage relational metadata by Apache Gravitino, 
relational metadata refers
-to relational catalog, schema, table and partitions. Through Gravitino, you 
can create, edit, and
+to relational catalog, schema, table, partitions and views. Through Gravitino, 
you can create, edit, and

Review Comment:
   This sentence lists multiple entities but uses singular nouns and misses a 
comma before the final item. Consider pluralizing for clarity and consistency 
(catalogs/schemas/tables) and using a comma-separated list (", and views") to 
improve readability in the introduction.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to