lasdf1234 commented on code in PR #11156:
URL: https://github.com/apache/gravitino/pull/11156#discussion_r3268327454


##########
docs/iceberg-rest-service.md:
##########
@@ -525,8 +525,8 @@ Gravitino features a pluggable cache system for updating or 
retrieving table met
 
 | Configuration item                                           | Description   
                              | Default value | Required | Since Version |
 
|--------------------------------------------------------------|---------------------------------------------|---------------|----------|---------------|
-| `gravitino.iceberg-rest.table-metadata-cache-impl`           | The implement 
of the cache.                 | (none)        | No       | 1.1.0         |
-| `gravitino.iceberg-rest.table-metadata-cache-capacity`       | The capacity 
of table metadata cache.       | 200           | No       | 1.1.0         |
+| `gravitino.iceberg-rest.table-metadata-cache-impl`           | The implement 
of the cache.                 | 
`org.apache.gravitino.iceberg.common.cache.LocalTableMetadataCache` | No       
| 1.1.0         |
+| `gravitino.iceberg-rest.table-metadata-cache-capacity`       | The capacity 
of table metadata cache.       | 1000          | No       | 1.1.0         |
 | `gravitino.iceberg-rest.table-metadata-cache-expire-minutes` | The expire 
minutes of table metadata cache. | 60            | No       | 1.1.0         |
 
 Gravitino provides the build-in 
`org.apache.gravitino.iceberg.common.cache.LocalTableMetadataCache` to store 
the cached data in the memory. You could also implement your custom table 
metadata cache by implementing the 
`org.apache.gravitino.iceberg.common.cache.TableMetadataCache` interface.

Review Comment:
   Extra modifications have been rolled back.



##########
docs/iceberg-rest-service.md:
##########
@@ -525,8 +525,8 @@ Gravitino features a pluggable cache system for updating or 
retrieving table met
 
 | Configuration item                                           | Description   
                              | Default value | Required | Since Version |
 
|--------------------------------------------------------------|---------------------------------------------|---------------|----------|---------------|
-| `gravitino.iceberg-rest.table-metadata-cache-impl`           | The implement 
of the cache.                 | (none)        | No       | 1.1.0         |
-| `gravitino.iceberg-rest.table-metadata-cache-capacity`       | The capacity 
of table metadata cache.       | 200           | No       | 1.1.0         |
+| `gravitino.iceberg-rest.table-metadata-cache-impl`           | The implement 
of the cache.                 | 
`org.apache.gravitino.iceberg.common.cache.LocalTableMetadataCache` | No       
| 1.1.0         |
+| `gravitino.iceberg-rest.table-metadata-cache-capacity`       | The capacity 
of table metadata cache.       | 1000          | No       | 1.1.0         |
 | `gravitino.iceberg-rest.table-metadata-cache-expire-minutes` | The expire 
minutes of table metadata cache. | 60            | No       | 1.1.0         |
 
 Gravitino provides the build-in 
`org.apache.gravitino.iceberg.common.cache.LocalTableMetadataCache` to store 
the cached data in the memory. You could also implement your custom table 
metadata cache by implementing the 
`org.apache.gravitino.iceberg.common.cache.TableMetadataCache` interface.

Review Comment:
   Extra modifications have been rolled back.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to