lasdf1234 commented on code in PR #11156:
URL: https://github.com/apache/gravitino/pull/11156#discussion_r3268334209


##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogPropertiesMetadata.java:
##########
@@ -127,13 +127,14 @@ public class IcebergCatalogPropertiesMetadata extends 
BaseCatalogPropertiesMetad
                 IcebergConstants.TABLE_METADATA_CACHE_IMPL,
                 "Table metadata cache implementation",
                 false /* immutable */,
-                null /* defaultValue */,
+                
"org.apache.gravitino.iceberg.common.cache.LocalTableMetadataCache"
+                    /* defaultValue */,
                 false /* hidden */),
             integerOptionalPropertyEntry(
                 IcebergConstants.TABLE_METADATA_CACHE_CAPACITY,
                 "Table metadata cache capacity",
                 false /* immutable */,
-                200 /* defaultValue */,
+                1000 /* defaultValue */,

Review Comment:
   Extra modifications have been rolled back.



##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogPropertiesMetadata.java:
##########
@@ -127,13 +127,14 @@ public class IcebergCatalogPropertiesMetadata extends 
BaseCatalogPropertiesMetad
                 IcebergConstants.TABLE_METADATA_CACHE_IMPL,
                 "Table metadata cache implementation",
                 false /* immutable */,
-                null /* defaultValue */,
+                
"org.apache.gravitino.iceberg.common.cache.LocalTableMetadataCache"
+                    /* defaultValue */,

Review Comment:
   Extra modifications have been rolled back.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to