lasdf1234 commented on code in PR #11156:
URL: https://github.com/apache/gravitino/pull/11156#discussion_r3272736425
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogPropertiesMetadata.java:
##########
@@ -127,13 +128,13 @@ public class IcebergCatalogPropertiesMetadata extends
BaseCatalogPropertiesMetad
IcebergConstants.TABLE_METADATA_CACHE_IMPL,
"Table metadata cache implementation",
false /* immutable */,
- null /* defaultValue */,
+ LocalTableMetadataCache.class.getName() /* defaultValue */,
Review Comment:
TABLE_METADATA_CACHE_IMPL has no default value, causing every default
deployment to fall back to TableMetadataCache.DUMMY. Every loadTable call reads
metadata.json from object storage on every request, with no caching. Latency
degrades silently as commit history grows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
