lasdf1234 commented on PR #11156:
URL: https://github.com/apache/gravitino/pull/11156#issuecomment-4505538641
> Could u check the logic?
>
> ```
> private TableMetadataCache loadTableMetadataCache(IcebergConfig config,
Catalog catalog) {
> String impl = config.get(IcebergConfig.TABLE_METADATA_CACHE_IMPL);
> if (StringUtils.isBlank(impl)) {
> return TableMetadataCache.DUMMY;
> }
>
> Preconditions.checkArgument(
> catalog instanceof SupportsMetadataLocation,
> "You shouldn't enable Iceberg metadata cache for the catalog %s,"
> + " because the catalog impl does not support get metadata
location.",
> catalog.name());
> ```
>
> Some catalog will throws exception if you changed the default value. Only
part of catalogs support metadata location.
Yes,
> Could u check the logic?
>
> ```
> private TableMetadataCache loadTableMetadataCache(IcebergConfig config,
Catalog catalog) {
> String impl = config.get(IcebergConfig.TABLE_METADATA_CACHE_IMPL);
> if (StringUtils.isBlank(impl)) {
> return TableMetadataCache.DUMMY;
> }
>
> Preconditions.checkArgument(
> catalog instanceof SupportsMetadataLocation,
> "You shouldn't enable Iceberg metadata cache for the catalog %s,"
> + " because the catalog impl does not support get metadata
location.",
> catalog.name());
> ```
>
> Some catalog will throws exception if you changed the default value. Only
part of catalogs support metadata location.
When implementing this requirement, I have already checked this part of the
logic, and only rest(hive),rest(jdbc),rest(memory) support cache.Should I
explain this issue in the irc doc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
