freesinger opened a new pull request, #11197:
URL: https://github.com/apache/gravitino/pull/11197

   ### What changes were proposed in this pull request?
   
   This PR handles the missing catalog case in Iceberg REST authorization skip 
checks.
   
   When `shouldSkipAuthorization()` checks whether the target catalog is a REST 
catalog, `getCatalogWrapper()` may throw `NoSuchCatalogException` if the 
catalog does not exist. This PR catches that exception and returns `false`, 
allowing the request to continue through the normal path where the missing 
catalog can be reported as a catalog-not-found error.
   
   ### Why are the changes needed?
   
   Fix: #11190
   
   Without this change, a missing catalog during the authorization skip check 
can be surfaced as an authorization internal error instead of the expected 
catalog-not-found behavior.
   
   ### Does this PR introduce any user-facing change?
   
   No API change.
   
   The error handling path is corrected for missing Iceberg REST catalogs.
   
   ### How was this patch tested?
   
   Added a unit test for the missing catalog skip-check path.
   
   Ran:
   
   `./gradlew :iceberg:iceberg-rest-server:test --tests 
org.apache.gravitino.server.web.filter.TestIcebergMetadataAuthorizationMethodInterceptor
 -PskipITs -PskipDockerTests=true`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to