Copilot commented on code in PR #11198:
URL: https://github.com/apache/gravitino/pull/11198#discussion_r3287259556
##########
docs/flink-connector/flink-catalog-jdbc.md:
##########
@@ -19,10 +19,16 @@ This document provides a comprehensive guide on configuring
and using Apache Gra
Place the following JAR files in the lib directory of your Flink installation:
--
[`flink-connector-jdbc-${flinkJdbcConnectorVersion}.jar`](https://nightlies.apache.org/flink/flink-docs-release-1.18/docs/connectors/table/jdbc/)
--
[`gravitino-flink-connector-runtime-1.18_2.12-${gravitino-version}.jar`](https://mvnrepository.com/artifact/org.apache.gravitino/gravitino-flink-connector-runtime-1.18)
+-
[`flink-connector-jdbc-${flinkJdbcConnectorVersion}.jar`](https://nightlies.apache.org/flink/flink-docs-release-1.20/docs/connectors/table/jdbc/)
Review Comment:
The JDBC connector JAR is referenced using a single placeholder version
(`flink-connector-jdbc-${flinkJdbcConnectorVersion}.jar`), but the table
immediately below documents different connector versions per Flink minor
version. This is internally inconsistent and may confuse users; consider
rewording the bullet to point readers to the per-version table (or remove the
single-version placeholder entirely).
##########
docs/flink-connector/flink-catalog-paimon.md:
##########
@@ -38,18 +38,24 @@ Supports most DDL and DML operations in Flink SQL, except
such operations:
## Requirement
-* Paimon 0.8
+* Paimon 1.2.0
Review Comment:
The Requirement section pins Paimon to a specific version (1.2.0), but the
artifact names in the table use a `${paimon-version}` placeholder. To avoid
ambiguity, consider either using the concrete version in the artifact examples
or changing the requirement wording to match the placeholder approach.
##########
docs/flink-connector/flink-catalog-iceberg.md:
##########
@@ -62,7 +77,7 @@ The Gravitino Flink connector transforms the following
properties in a catalog t
| Gravitino catalog property name | Flink Iceberg connector configuration |
Description
| Since Version |
|---------------------------------|---------------------------------------|---------------------------------------------------------------------------------------------------------------|------------------|
-| `catalog-backend` | `catalog-type` |
Catalog backend type, currently, only `Hive` Catalog is supported, `JDBC` and
`Rest` in Continuous Validation | 0.8.0-incubating |
+| `catalog-backend` | `catalog-type` |
Catalog backend type, currently, `Hive` and `Rest` catalogs are supported,
`JDBC` in Continuous Validation | 0.8.0-incubating |
Review Comment:
The description text is grammatically incomplete: "`JDBC` in Continuous
Validation" is missing a verb and reads ambiguously. Consider rewriting to
something like "...and `JDBC` is in continuous validation" (and optionally
standardize "Rest" to "REST" if that’s the intended term).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
