mchades commented on code in PR #11226:
URL: https://github.com/apache/gravitino/pull/11226#discussion_r3302630647


##########
docs/security/how-to-authenticate.md:
##########
@@ -43,6 +43,31 @@ curl -v -X GET \
   http://localhost:8090/api/version
 ```
 
+### Basic mode
+
+In Basic mode, Gravitino verifies HTTP Basic credentials against built-in IdP 
user metadata stored
+in the relational entity store.
+
+To enable Basic mode:
+
+- Set `gravitino.entity.store` to `relational` and configure the relational 
JDBC backend.
+- Set `gravitino.authenticators` to `basic`.
+- Set `gravitino.authorization.serviceAdmins` to the service admin usernames 
that should exist in
+  the built-in IdP.

Review Comment:
   Should "Idp" or "IDP" be used? It appears that the latter is correct.



##########
docs/security/how-to-authenticate.md:
##########
@@ -43,6 +43,31 @@ curl -v -X GET \
   http://localhost:8090/api/version
 ```
 
+### Basic mode
+
+In Basic mode, Gravitino verifies HTTP Basic credentials against built-in IdP 
user metadata stored
+in the relational entity store.

Review Comment:
   Is the basic authentication mode tied to the IDP and relational store? Is 
this design appropriate? cc @roryqi 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to