Copilot commented on code in PR #11242:
URL: https://github.com/apache/gravitino/pull/11242#discussion_r3308601911
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/listener/api/event/IcebergReplaceViewEvent.java:
##########
@@ -54,6 +54,6 @@ public LoadViewResponse loadViewResponse() {
@Override
public OperationType operationType() {
- return OperationType.ALTER_VIEW;
+ return OperationType.REPLACE_VIEW;
}
Review Comment:
`IcebergReplaceViewEvent` exposes `renameViewRequest()` but it returns the
replace-view request (`UpdateTableRequest`). This is inconsistent with
`IcebergReplaceViewPreEvent`/`IcebergReplaceViewFailureEvent` which use
`replaceViewRequest()`, and it’s easy for listeners to misinterpret the
payload. Consider adding a correctly named `replaceViewRequest()` accessor on
the success event and deprecating (or delegating from) the existing
`renameViewRequest()` method for backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
