FANNG1 commented on code in PR #11219:
URL: https://github.com/apache/gravitino/pull/11219#discussion_r3315231545
##########
catalogs/catalog-lakehouse-iceberg/src/test/java/org/apache/gravitino/catalog/lakehouse/iceberg/converter/TestConvertUtil.java:
##########
@@ -460,8 +460,8 @@ public void testFormIcebergType() {
@Test
public void testFromNestedField() {
- String colName = RandomStringUtils.randomAlphabetic(10);
- String doc = RandomStringUtils.randomAlphabetic(20);
+ String colName = RandomStringUtils.secure().nextAlphabetic(10);
Review Comment:
any reason to do the method replace?
##########
catalogs/catalog-lakehouse-iceberg/src/test/java/org/apache/gravitino/catalog/lakehouse/iceberg/integration/test/CatalogIcebergBaseIT.java:
##########
@@ -1173,7 +1173,7 @@ public void testTableDistribution() {
sortOrders);
});
Assertions.assertTrue(
- StringUtils.contains(
+ Strings.CS.contains(
Review Comment:
any reason to do the method replace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
