bharos commented on code in PR #10918:
URL: https://github.com/apache/gravitino/pull/10918#discussion_r3315584558
##########
server-common/src/main/java/org/apache/gravitino/server/authorization/annotations/ExpressionCondition.java:
##########
@@ -16,7 +16,11 @@
* specific language governing permissions and limitations
* under the License.
*/
+package org.apache.gravitino.server.authorization.annotations;
-package org.apache.gravitino.flink.connector.integration.test.iceberg;
-
-public class FlinkIcebergHiveCatalogIT118 extends FlinkIcebergHiveCatalogIT {}
+public enum ExpressionCondition {
+ NEVER,
+ ALWAYS,
+ PREVIOUS_EXPRESSION_FORBIDDEN,
Review Comment:
Seems like this value is unused ?
Should we remove this
##########
server-common/src/main/java/org/apache/gravitino/server/authorization/annotations/AuthorizationExpression.java:
##########
@@ -38,6 +38,8 @@
*/
String expression() default "";
+ ExpressionCondition expressionCondition() default ExpressionCondition.ALWAYS;
Review Comment:
Is this unused ?
##########
server-common/src/main/java/org/apache/gravitino/server/authorization/expression/AuthorizationExpressionConstants.java:
##########
Review Comment:
Remove this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
