roryqi commented on code in PR #11219:
URL: https://github.com/apache/gravitino/pull/11219#discussion_r3316617187
##########
docs/docker-image-details.md:
##########
@@ -86,6 +86,9 @@ Use `GRAVITINO_MEM` to size the JVM (default `-Xms1024m
-Xmx1024m -XX:MaxMetaspa
Changelog
+- apache/gravitino-iceberg-rest:1.3.0
Review Comment:
You don't need to update this document.
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/IcebergRESTUtils.java:
##########
Review Comment:
What's the relationship between `RESTUtil` and `IcebergRESTUtils`? Why do we
need this modification?
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java:
##########
@@ -528,6 +492,44 @@ public PlanTableScanResponse planTableScan(
}
}
+ /**
+ * Builds a synchronous COMPLETED scan plan response for Iceberg 1.11+ REST
clients only.
+ *
+ * <p>Populates {@code file-scan-tasks} and does not populate legacy {@code
plan-tasks}, which is
+ * incompatible with pre-1.11 REST clients that deserialize scan tasks from
JSON strings.
+ *
+ * <p>{@code withSpecsById} is deprecated in Iceberg 1.11 but required for
structured task
+ * encoding. Remove when upstream provides a non-deprecated replacement
(planned in 1.12).
+ */
+ @SuppressWarnings("deprecation")
Review Comment:
Why do u use this annotation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
