roryqi commented on code in PR #11294:
URL: https://github.com/apache/gravitino/pull/11294#discussion_r3338077626


##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/CatalogWrapperForREST.java:
##########
@@ -336,9 +333,7 @@ protected LoadTableResponse injectCredentialConfig(
         .build();
   }
 
-  private Credential getCredential(
-      LoadTableResponse loadTableResponse, CredentialPrivilege privilege) {
-    TableMetadata tableMetadata = loadTableResponse.tableMetadata();
+  private Credential getCredential(TableMetadata tableMetadata, 
CredentialPrivilege privilege) {

Review Comment:
   If the catalog backend is a REST catalog backend, it should retrieve the 
credential from the catalog backend instead generating a credential in the 
local mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to