roryqi commented on code in PR #11299:
URL: https://github.com/apache/gravitino/pull/11299#discussion_r3338906039
##########
iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/cleanup/AbstractIcebergCleanupJobStoreBackendTest.java:
##########
@@ -100,36 +100,46 @@ void testAddTakeSucceedLifecycle() {
Assertions.assertTrue(store.findUnfinishedJobId(CATALOG_ID, "db",
"t").isPresent());
Assertions.assertFalse(store.takePendingJob(now, 300_000L,
10).isPresent());
- Assertions.assertTrue(store.markSucceeded(id));
+ Assertions.assertTrue(store.markSucceeded(id, now));
Assertions.assertEquals(IcebergCleanupJob.State.SUCCEEDED,
store.stateOf(id));
// A second transition no longer owns the (now terminal) row, so it
reports no update.
- Assertions.assertFalse(store.markSucceeded(id));
+ Assertions.assertFalse(store.markSucceeded(id, now));
Assertions.assertFalse(store.findUnfinishedJobId(CATALOG_ID, "db",
"t").isPresent());
Assertions.assertEquals(
1, store.deleteFinishedJobsByLegacyTimeline(System.currentTimeMillis()
+ 1));
}
- @TestTemplate
- void testMarkFailed() {
- long id = store.addJob(sampleJob());
- store.takePendingJob(System.currentTimeMillis(), 300_000L, 10);
- Assertions.assertTrue(store.markFailed(id, "corrupt metadata"));
- Assertions.assertEquals(IcebergCleanupJob.State.FAILED, store.stateOf(id));
- }
-
@TestTemplate
void testTransientFailureRetriesThenFailsAtCeiling() {
long id = store.addJob(sampleJob());
Review Comment:
Added the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
