Copilot commented on code in PR #11361:
URL: https://github.com/apache/gravitino/pull/11361#discussion_r3345778324
##########
server-common/src/test/java/org/apache/gravitino/server/web/TestJettyServerConfig.java:
##########
@@ -62,8 +62,21 @@ public void testCipherAlgorithms() {
@Test
public void testCustomFilters() {
- Config emptyconfig = new Config() {};
- JettyServerConfig jettyServerConfig =
JettyServerConfig.fromConfig(emptyconfig, "");
+ Config emptyConfig = new Config() {};
+ JettyServerConfig jettyServerConfig =
JettyServerConfig.fromConfig(emptyConfig, "");
+ Assertions.assertNotNull(jettyServerConfig.getCustomFilters());
+ Assertions.assertTrue(jettyServerConfig.getCustomFilters().isEmpty());
+
+ Config quotedEmptyConfig = new Config() {};
+ quotedEmptyConfig.set(JettyServerConfig.CUSTOM_FILTERS,
Optional.of("\"\""));
+ jettyServerConfig = JettyServerConfig.fromConfig(quotedEmptyConfig, "");
+ Assertions.assertNotNull(jettyServerConfig.getCustomFilters());
+ Assertions.assertTrue(jettyServerConfig.getCustomFilters().isEmpty());
+
+ Config singleQuotedEmptyConfig = new Config() {};
+ singleQuotedEmptyConfig.set(JettyServerConfig.CUSTOM_FILTERS,
Optional.of("''"));
+ jettyServerConfig = JettyServerConfig.fromConfig(singleQuotedEmptyConfig,
"");
+ Assertions.assertNotNull(jettyServerConfig.getCustomFilters());
Assertions.assertTrue(jettyServerConfig.getCustomFilters().isEmpty());
Review Comment:
`JettyServerConfig` now trims entries and filters out blank tokens in
addition to quote-only values, but `testCustomFilters` only asserts the
quote-only behavior. Adding a mixed/whitespace case (e.g., spaces + empty
tokens + ""/'' entries) would ensure the new trimming/blank-filtering logic is
covered and prevent regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
