JoegenUSTC commented on PR #11355: URL: https://github.com/apache/gravitino/pull/11355#issuecomment-4610408685
> The CI fails. Can you take time to fix it? @JoegenUSTC @yuqi1129 Thanks for flagging this! I've fixed the CI failure in commit `11fbb32`. The root cause was that `TestHive2HMSWithKerberosNoImpersonation.startHiveContainer()` was redundantly constructing a second `HiveClientFactory` after `super.startHiveContainer()`. Since `TestHive2HMSWithKerberos.startHiveContainer()` already calls `createHiveProperties()` via polymorphism, the overridden `createHiveProperties()` (with `impersonation-enable=false`) was already in effect for the initial `hiveClient` creation. The redundant second construction failed in the CI Kerberos environment, leaving `hiveClient=null` and causing NPE in all test methods. The fix removes the `startHiveContainer()` override entirely — only `createHiveProperties()` needs to be overridden. All tests pass locally (`./gradlew :catalogs:hive-metastore-common:test -PskipITs`). Could you please approve the CI workflows to run? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
