Copilot commented on code in PR #11418:
URL: https://github.com/apache/gravitino/pull/11418#discussion_r3353004638
##########
web-v2/web/src/components/Icons.js:
##########
@@ -153,6 +153,22 @@ const Icons = {
</g>
</svg>
),
+ glue: props => (
+ <svg {...props} xmlns='http://www.w3.org/2000/svg' width='1em'
height='1em' viewBox='0 0 256 256'>
+ <path d='M0 0h256v256H0z' fill='none' />
+ <defs>
+ <linearGradient id='SVGusebDeuy' x1='0%' x2='100%' y1='100%' y2='0%'>
+ <stop offset='0%' stop-color='#4d27a8' />
+ <stop offset='100%' stop-color='#a166ff' />
+ </linearGradient>
Review Comment:
In React JSX for SVG, the `stop-color` attribute should be camelCased
(`stopColor`). With the current attribute name, React can drop/ignore it,
causing the gradient colors to not render as intended.
##########
web-v2/web/src/app/catalogs/rightContent/CreateSchemaDialog.js:
##########
@@ -132,11 +139,21 @@ export default function CreateSchemaDialog({ ...props }) {
}, [open, editSchema, metalake, catalog])
Review Comment:
This effect now branches on `isGlueProvider`, but its dependency array
doesn’t include `provider` (or `isGlueProvider`). If `provider` is
populated/updated after the dialog opens (it is passed from catalog details),
the effect won’t re-run and the form can be initialized using the wrong branch.
##########
web-v2/web/src/config/catalog.js:
##########
@@ -282,6 +347,62 @@ export const rangerDefaultProps = [
]
export const providerBase = {
+ glue: {
+ label: 'AWS Glue',
+ defaultProps: [
+ {
+ label: 'AWS Region',
+ key: 'aws-region',
+ value: '',
+ required: true,
+ description: 'AWS region, e.g. us-east-1'
+ },
+ {
+ label: 'Warehouse',
+ key: 'warehouse',
+ value: '',
+ required: true,
+ description: 'S3 base path, e.g. s3://my-bucket/warehouse'
+ },
+ {
+ label: 'AWS Glue Catalog ID',
+ key: 'aws-glue-catalog-id',
+ value: '',
+ description: "12-digit AWS account ID; defaults to caller's account"
+ },
+ {
+ label: 'AWS Access Key ID',
+ key: 'aws-access-key-id',
+ value: '',
+ description: 'Static credential; omit to use default credential chain'
+ },
+ {
+ label: 'AWS Secret Access Key',
+ key: 'aws-secret-access-key',
+ value: '',
+ description: 'Static credential paired with aws-access-key-id'
+ },
Review Comment:
`aws-secret-access-key` is a sensitive credential but the create-catalog
form currently only masks `jdbc-password` fields. As a result, this value will
be rendered as a plain text `<Input>` and be visible while typing
(shoulder-surfing / screen recording risk).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
