jerryshao commented on code in PR #11354:
URL: https://github.com/apache/gravitino/pull/11354#discussion_r3353385412
##########
core/src/main/java/org/apache/gravitino/job/JobManager.java:
##########
@@ -808,6 +809,7 @@ static String fetchFileFromUri(String uri, File stagingDir,
int timeoutInMs) {
case "http":
case "https":
case "ftp":
+ validateRemoteUri(fileUri);
Review Comment:
There're several `FetchFileUtils` that have similar code. I think you should
1) Fix the similar issues for all of them; 2) Consolidate the similar code into
one if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
