yuqi1129 commented on code in PR #11304:
URL: https://github.com/apache/gravitino/pull/11304#discussion_r3355805361
##########
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystemConfiguration.java:
##########
@@ -109,6 +113,18 @@ public class GravitinoVirtualFileSystemConfiguration {
public static final long
FS_GRAVITINO_FILESET_CACHE_EVICTION_MILLS_AFTER_ACCESS_DEFAULT =
1000L * 60 * 60;
+ /**
+ * Whether to close the underlying {@code FileSystem} immediately on cache
eviction. Default is
+ * {@code false}: close is deferred to GVFS shutdown to avoid breaking
long-lived streams (see <a
+ * href="https://github.com/apache/gravitino/issues/11303";>#11303</a>). Set
to {@code true} to
+ * fall back to the legacy behaviour.
+ */
+ public static final String FS_GRAVITINO_FILESET_CACHE_CLOSE_ON_EVICTION_KEY =
+ "fs.gravitino.fileset.cache.closeOnEviction";
+
+ /** The default value for {@link
#FS_GRAVITINO_FILESET_CACHE_CLOSE_ON_EVICTION_KEY}. */
+ public static final boolean
FS_GRAVITINO_FILESET_CACHE_CLOSE_ON_EVICTION_DEFAULT = false;
Review Comment:
Can you also add some documents about this configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
