mchades commented on code in PR #11349:
URL: https://github.com/apache/gravitino/pull/11349#discussion_r3361414102
##########
flink-connector/flink-common/src/main/java/org/apache/gravitino/flink/connector/catalog/BaseCatalog.java:
##########
@@ -332,6 +333,16 @@ public void dropTable(ObjectPath tablePath, boolean
ignoreIfNotExists)
}
}
+ /**
+ * Drops the table entry. Subclasses may override to use a different drop
strategy (e.g., purge).
Review Comment:
How can different drop strategies, such as purge, be controlled when the
function parameter is limited to `NameIdentifier`?
##########
api/src/main/java/org/apache/gravitino/rel/Dialects.java:
##########
@@ -39,5 +39,12 @@ public final class Dialects {
/** The Apache Flink SQL dialect. */
public static final String FLINK = "flink";
+ /**
+ * A dialect key for the canonical SQL representation of a view, used as a
fallback when no
+ * engine-specific dialect (e.g. {@link #FLINK}, {@link #HIVE}) is available
or preserved by the
+ * underlying metastore.
+ */
+ public static final String QUERY_DIALECT = "query";
Review Comment:
Only the Paimon catalog utilizes `query`, so it is unnecessary to include it
in the API module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
