mchades commented on code in PR #11292:
URL: https://github.com/apache/gravitino/pull/11292#discussion_r3362871774


##########
catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/HiveCatalogOperations.java:
##########
@@ -697,12 +697,21 @@ public Table alterTable(NameIdentifier tableIdent, 
TableChange... changes)
       String newComment = currentTable.comment();
       Map<String, String> updatedProperties = new 
HashMap<>(currentTable.properties());
       List<Column> updatedColumns = new 
ArrayList<>(Arrays.asList(currentTable.columns()));
+      // Use the loaded table's database name as the default.
+      // If a new schema is explicitly requested during a rename, this will be 
overwritten below.
+      String targetDatabaseName = currentTable.databaseName();

Review Comment:
   Could you please add an integration test to cover the changes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to