Copilot commented on code in PR #11485:
URL: https://github.com/apache/gravitino/pull/11485#discussion_r3371621085
##########
web-v2/web/src/config/catalog.js:
##########
@@ -148,16 +153,19 @@ export const tableDefaultProps = {
{
key: 'metadata_location',
defaultValue: '',
+ hide: ['hive'],
description: 'Iceberg metadata file path'
},
{
key: 'format',
defaultValue: '',
+ hide: ['iceberg'],
select: ['TEXTFILE', 'SEQUENCEFILE', 'RCFILE', 'ORC', 'PARQUET', 'AVRO',
'JSON', 'CSV', 'REGEX']
Review Comment:
For Glue tables, `format` defaults to empty while `input-format` defaults to
TextInputFormat. When a user selects `table-format=HIVE` but leaves `format`
unset, the UI will submit `input-format`/`output-format`/`serde-lib` defaults
without a `format` value. On the server side, Glue defaults `format` to PARQUET
when missing, and since class names are present it will not auto-translate
them, producing an inconsistent StorageDescriptor (e.g., PARQUET +
TextInputFormat). Consider defaulting `format` (and the corresponding class
defaults) consistently (e.g., PARQUET).
##########
web-v2/web/src/config/catalog.js:
##########
@@ -173,6 +181,7 @@ export const tableDefaultProps = {
{
key: 'output-format',
defaultValue:
'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat',
+ hide: ['iceberg'],
defaultValueOptions: {
Review Comment:
With `format` potentially unset for Glue/Hive tables, `output-format` should
also default consistently with the chosen default storage format (e.g.,
PARQUET). Otherwise the UI may submit a default output format for TEXTFILE
while the server assumes PARQUET when `format` is absent.
##########
web-v2/web/src/config/catalog.js:
##########
@@ -188,6 +197,7 @@ export const tableDefaultProps = {
{
key: 'serde-lib',
defaultValue: 'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe',
+ hide: ['iceberg'],
defaultValueOptions: {
Review Comment:
Similarly, `serde-lib` defaults for Glue/Hive tables should align with the
default `format` to avoid sending Parquet/ORC/etc. mismatched with the SerDe
class (or vice versa) when the user doesn't explicitly set `format`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
