yuqi1129 commented on code in PR #11484:
URL: https://github.com/apache/gravitino/pull/11484#discussion_r3371805162
##########
build.gradle.kts:
##########
@@ -336,12 +336,16 @@ subprojects {
apply(plugin = "maven-publish")
apply(plugin = "java")
- // Force upgrade commons-beanutils/snappy-java for all subprojects to
resolve outdated transitive versions
+ // Force upgrade commons-beanutils/snappy-java/slf4j-api for all subprojects
to resolve outdated transitive versions
// commons-beanutils: pulled by Hadoop, Hive, Spark, Flink, etc.
// snappy-java: pulled by Hadoop, Kafka, Iceberg, etc.
+ // slf4j-api: log4j-slf4j2-impl:2.25.4 requires 2.0.17, while the catalog
pins 2.0.16; without
+ // this force different subprojects resolve to different versions and both
jars end up in the
+ // distribution lib directory simultaneously. Force to 2.0.17 so all
subprojects converge.
configurations.all {
resolutionStrategy.force("commons-beanutils:commons-beanutils:$commonsBeanutilsVersion")
resolutionStrategy.force("org.xerial.snappy:snappy-java:$snappyJavaVersion")
+ resolutionStrategy.force("org.slf4j:slf4j-api:2.0.17")
Review Comment:
> Can you check which module introduced the 2.0.16 jar?
slf4j-api-2.0.16.jar — from modules that only see the catalog-pinned
version. see
https://github.com/apache/gravitino/blob/d8e65d749fe3ee31562e204d70a29378525b4ad8/gradle/libs.versions.toml#L31
slf4j-api-2.0.17.jar — from modules using bundles.log4j (core, server,
server-common), where log4j-slf4j2-impl:2.25.4 declares a transitive dependency
on slf4j-api:2.0.17
> Use the variable, don't hardcode the version number here.
I will change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
