danhuawang opened a new pull request, #11494:
URL: https://github.com/apache/gravitino/pull/11494
### What changes were proposed in this pull request?
Replace hardcoded SNAPSHOT version assertions in Helm chart unit tests with
matchRegex pattern matching, avoiding CI failures on every version bump.
Changed files:
deployment_test.yaml
deployment_test.yaml
Both files changed from:
```
- equal:
path: spec.template.spec.containers[0].image
value: apache/gravitino-xxx:1.3.0-SNAPSHOT
```
to:
```
- matchRegex:
path: spec.template.spec.containers[0].image
pattern: "^apache/gravitino-xxx:.+"
```
This aligns with the existing approach in
deployment_test.yaml
### Why are the changes needed?
The chart unit tests hardcode SNAPSHOT version strings (e.g.,
1.3.0-SNAPSHOT). After every version bump, these tests fail and require manual
updates, adding unnecessary maintenance burden. For example, the current CI
failure:
```
Expected: apache/gravitino-iceberg-rest:1.3.0-SNAPSHOT
Actual: apache/gravitino-iceberg-rest:1.3.1-SNAPSHOT
```
Using matchRegex ensures the test validates the image repository is correct
and a tag is present, without coupling to a specific version.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
helm unittest --with-subchart=false dev/charts/gravitino-iceberg-rest-server
helm unittest --with-subchart=false dev/charts/gravitino-lance-rest-server
helm unittest --with-subchart=false dev/charts/gravitino
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
