danhuawang opened a new pull request, #11514:
URL: https://github.com/apache/gravitino/pull/11514
### What changes were proposed in this pull request?
This PR includes the enterprise readiness cleanups for the Helm chart
(authored by @markhoerth) plus follow-up fixes for template correctness and CI
stability issues discovered during review.
**Commit 1 (by @markhoerth):** `feat(helm): enterprise readiness cleanups
for chart`
- Remove vendor-specific property references from ci-values.yaml and
values.yaml
- Add structured values.yaml paths for entity.maxConnections, lock.maxNodes,
and lock.minNodes
- Ship dev-values.yaml and prod-values.yaml scenario files
- Replace NOTES.txt with a post-install deployment summary with runtime
warnings
- Add default-credential warnings for mysql and postgresql sections
- Emit dynamic-config-provider sub-properties conditionally
**Commit 2 (follow-up fixes):**
1. **Conditional OAuth rendering** (`gravitino.conf`): Wrap all
`gravitino.authenticator.oauth.*` properties in `{{- if contains "oauth"
.Values.authenticators }}` with per-property guards. Previously these
properties were rendered unconditionally with empty values even in simple-auth
mode, overriding server defaults.
2. **Fix H2 backend detection** (`NOTES.txt`): Replace exact-match `eq
"jdbc:h2"` with `hasPrefix "jdbc:h2"` so H2 file-mode URLs are correctly
identified.
3. **Fix CI crash** (`ci-values.yaml`): Replace
`gravitino.eventListener.names: "audit,sync"` with
`gravitino.server.shutdown.timeout: "5000"`. The eventListener config declared
listeners without the required `.class` properties, causing server startup
failure.
4. **Document additionalConfigItems usage** (`values.yaml`): Add complete
commented example for event listener configuration.
5. **Migrate to non-deprecated entrypoint** (`values.yaml`,
`pg-values.yaml`): Replace `bin/start-gravitino.sh` with
`docker/docker-entrypoint.sh` to align with the Dockerfile ENTRYPOINT.
### Why are the changes needed?
- Empty OAuth properties override server defaults silently.
- The H2 detection bug suppresses the data-loss warning for H2 file-mode
URLs.
- The `eventListener.names` config without `class` properties crashes the
server during CI chart tests.
- The deprecated `start-gravitino.sh` generates unnecessary warning noise
and will break when removed.
Fix: #11268
### Does this PR introduce _any_ user-facing change?
- When `authenticators` is `simple` (default), `gravitino.conf` no longer
contains empty `gravitino.authenticator.oauth.*` lines.
- NOTES.txt correctly classifies H2 file-mode JDBC URLs as "Embedded H2".
- The deprecation warning from `bin/start-gravitino.sh` no longer appears in
pod logs.
### How was this patch tested?
- Ran `helm template` with default values (simple auth) — no
`authenticator.oauth` lines emitted.
- Ran `helm template` with `prod-values.yaml` (oauth) — all configured OAuth
properties render correctly.
- Ran `helm template` with `ci-values.yaml` —
`gravitino.server.shutdown.timeout = 5000` renders in additionalConfigItems
section.
- All template renderings compile without errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
