Copilot commented on code in PR #11552:
URL: https://github.com/apache/gravitino/pull/11552#discussion_r3385447929
##########
web-v2/web/package.json:
##########
@@ -56,7 +56,7 @@
"@next/bundle-analyzer": "^14.2.4",
"@types/lodash-es": "^4.17.12",
"@types/node": "^20.14.9",
- "@types/qs": "^6.14.0",
+ "@types/qs": "^6.15.1",
"@types/react": "^18.3.3",
"@vitest/coverage-v8": "^2.1.9",
Review Comment:
`@vitest/coverage-v8` is still pinned to v2.x while vitest was upgraded to
v3.x. The lockfile shows @vitest/[email protected] declaring a peerDependency
on vitest 2.1.9, which is incompatible with vitest 3.2.6 and can break `pnpm
test:coverage` (or at least produce peer mismatch warnings). Upgrade
`@vitest/coverage-v8` to the matching v3.x line so its peerDependencies align
with the new vitest version.
##########
web-v2/web/package.json:
##########
@@ -70,7 +70,7 @@
"tailwindcss": "^3.4.4",
"tsx": "^4.16.0",
"typescript": "^5.5.3",
- "vitest": "^2.1.9"
+ "vitest": "^3.2.6"
Review Comment:
vitest is upgraded from 2.x to 3.x here, but it is not mentioned in the PR
description and the testing section is marked N/A. Since this is a major
version bump and the repo has vitest-based unit tests under web-v2/web, please
document the vitest upgrade in the PR description and include the results of
running `pnpm test` / `pnpm test:coverage` for this package.
##########
web-v2/web/package.json:
##########
@@ -25,7 +25,7 @@
"@hookform/resolvers": "^3.7.0",
"@reduxjs/toolkit": "^1.9.7",
"antd": "^5.24.5",
- "axios": "^1.15.2",
+ "axios": "^1.16.0",
Review Comment:
The PR description says axios is being upgraded to "1.1.6.0", but the actual
change upgrades it to ^1.16.0 (resolved to 1.16.1 in pnpm-lock). Please update
the PR description to match the real version (and avoid the non-existent/typo
version string).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
