somaz94 commented on PR #11308: URL: https://github.com/apache/gravitino/pull/11308#issuecomment-4676395747
@jerryshao Conflicts resolved — rebased onto the latest `main` (`1693ec5f`). One note on the resolution: the only real conflict was in `.github/workflows/chart-test.yaml`. While this PR was open, upstream independently added the same `helm unittest` steps for the `gravitino` and `gravitino-lance-rest-server` charts that I had added per @danhuawang's review. Since they are identical, I dropped my redundant change, so this PR no longer touches `chart-test.yaml`. The new `tests/httproute_test.yaml` suites still get exercised, because the now-upstream CI wiring runs `helm unittest` on all three charts. Local validation on the rebased branch: - `helm unittest --with-subchart=false` — gravitino (36 tests), gravitino-iceberg-rest-server (30 tests), gravitino-lance-rest-server (29 tests), all pass - `helm lint` — all three charts pass Ready for another look. 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
