Copilot commented on code in PR #11605:
URL: https://github.com/apache/gravitino/pull/11605#discussion_r3397903702
##########
core/src/main/java/org/apache/gravitino/GravitinoEnv.java:
##########
@@ -699,6 +729,7 @@ private void initGravitinoServerComponents() {
TopicOperationDispatcher topicOperationDispatcher =
new TopicOperationDispatcher(catalogManager, entityStore, idGenerator);
+ this.internalTopicDispatcher = topicOperationDispatcher;
TopicNormalizeDispatcher topicNormalizeDispatcher =
new TopicNormalizeDispatcher(topicOperationDispatcher, catalogManager);
Review Comment:
`internalTopicDispatcher` is currently wired to `TopicOperationDispatcher`,
which bypasses `TopicNormalizeDispatcher`. Internal callers may therefore skip
capability/case-sensitivity normalization, leading to inconsistent behavior
compared to user-facing dispatchers and other internal dispatchers. Point
`internalTopicDispatcher` at the normalize dispatcher (still no hooks/events).
##########
core/src/main/java/org/apache/gravitino/GravitinoEnv.java:
##########
@@ -691,6 +720,7 @@ private void initGravitinoServerComponents() {
FilesetOperationDispatcher filesetOperationDispatcher =
new FilesetOperationDispatcher(catalogManager, entityStore,
idGenerator);
+ this.internalFilesetDispatcher = filesetOperationDispatcher;
FilesetNormalizeDispatcher filesetNormalizeDispatcher =
new FilesetNormalizeDispatcher(filesetOperationDispatcher,
catalogManager);
Review Comment:
`internalFilesetDispatcher` is currently wired to
`FilesetOperationDispatcher`, which skips the normalization layer
(`FilesetNormalizeDispatcher`). This makes internal callers (e.g.,
authorization/location lookups) bypass capability/case-sensitivity
normalization and can cause incorrect lookups for catalogs with non-default
case-sensitivity rules. Wire the internal dispatcher to the normalize
dispatcher (still no hooks/events) to match the behavior of other internal
dispatchers (catalog/schema/table/view).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
