yuqi1129 commented on code in PR #11354:
URL: https://github.com/apache/gravitino/pull/11354#discussion_r3400037540
##########
catalogs/catalog-fileset/src/main/java/org/apache/gravitino/catalog/fileset/FilesetCatalogOperations.java:
##########
@@ -1386,7 +1386,10 @@ FileSystem getFileSystem(Path path, Map<String, String>
config) throws IOExcepti
() -> {
if (scheme.equals(SCHEME_HDFS)) {
return new ImpersonationHDFSFileSystemProxy(
- path, config, PrincipalUtils::getCurrentUserName)
+ path,
+ config,
+ PrincipalUtils::getCurrentUserName,
+ GravitinoEnv.getInstance().blockUnsafeRemoteUri())
Review Comment:
@jerryshao
The initial code is what you suggested. see
https://github.com/apache/gravitino/pull/11354#discussion_r3395339830
@roryqi He would like to make `blockUnsafeRemoteUri` a method and believes
using a static field to store it is not a good idea. Frankly, these two are
also acceptable to me; the current option( method parameter) is consistent with
other configurations like `cacheEnabled`, but it seems to be tedious. The
option to make it as `static` field is not so elegant, but it did make the code
simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
