mchades commented on PR #11618: URL: https://github.com/apache/gravitino/pull/11618#issuecomment-4706151814
**Residual risk: Missing integration test for uncaught servlet errors** **Location:** `server-common/src/test/java/org/apache/gravitino/server/web/TestHttpAuditFilter.java` around line 408 **Issue:** While the unit tests cover most scenarios, there's no integration test verifying correct audit event handling for: - Uncaught servlet errors (DispatcherType.ERROR) - Exception escaping without being caught by filters - Ensuring no duplicate or missing 500 audit events during error dispatch **Recommendation:** Add an integration test (`HttpAuditFilterIT` or similar) that: 1. Triggers a true servlet error (e.g., JSP compilation error, uncaught exception in servlet initialization) 2. Verifies exactly one audit event is emitted 3. Confirms DispatcherType.ERROR requests don't bypass or double-log events This prevents the audit trail from missing or duplicating events when errors bubble up from the servlet layer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
