mchades commented on code in PR #11622: URL: https://github.com/apache/gravitino/pull/11622#discussion_r3418901118
########## mcp-server/mcp_server/client/plain/plain_rest_client_operation.py: ########## @@ -62,8 +62,23 @@ # pylint: disable=too-many-instance-attributes class PlainRESTClientOperation(GravitinoOperation): - def __init__(self, metalake_name: str, uri: str): - _rest_client = httpx.AsyncClient(base_url=uri) + def __init__(self, metalake_name: str, uri: str, authorization: str = ""): + """Create a REST client for one identity. + + Args: + metalake_name: Name of the metalake. + uri: Gravitino server URI. + authorization: Full ``Authorization`` header value forwarded verbatim + on every request (for example ``"Bearer <token>"`` for OAuth2 or + ``"Basic <base64(user:dummy)>"`` for simple auth). Empty string Review Comment: this also for basic auth, which we recently supported for local IDP, not only simple auth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
