sachinnn99 commented on PR #10800: URL: https://github.com/apache/gravitino/pull/10800#issuecomment-4720343151
@laserninja Thanks for the thorough review! I've addressed all five points in the latest push: **[HIGH] Dispatcher bypass** — Moved credential vending from the REST layer (`IcebergTableOperations`) into the executor and wrapper, matching the `loadTable` credential pattern. `IcebergTableOperationExecutor.planTableScan()` now determines privilege via `getCredentialPrivilege()` instead of hardcoding READ. **[HIGH] Broad catch** — Eliminated the `catch(Exception)` from the REST layer entirely. Only `ServiceUnavailableException` is caught (inside the wrapper's `injectScanCredentials`), so auth failures and config errors now propagate correctly. **[HIGH] Redundant loadTable** — `CatalogWrapperForREST.planTableScan()` now reuses the `Table` object already loaded for scan planning to generate credentials. No second `loadTable` call. Added `getCredentialFromTable(Table, CredentialPrivilege)` which extracts the same location/properties that `getCredential(TableMetadata, ...)` reads. **[MEDIUM] Fragile JSON merge** — Added TODO noting the builder reconstruction is a workaround until PlanTableScanResponse supports native credential fields. **[MEDIUM] Missing prefix assertion** — Added `prefix` assertion in the S3 credential vending test verifying it matches the table location. @roryqi Conflicts with main are resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
