laserninja commented on code in PR #11634:
URL: https://github.com/apache/gravitino/pull/11634#discussion_r3430716618
##########
iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/IcebergRestTestUtil.java:
##########
@@ -139,9 +148,15 @@ public static ResourceConfig getIcebergResourceConfig(
IcebergConfigProvider configProvider =
IcebergConfigProviderFactory.create(catalogConf);
configProvider.initialize(catalogConf);
// used to override register table interface
- IcebergCatalogWrapperManager icebergCatalogWrapperManager =
- new IcebergCatalogWrapperManagerForTest(
- catalogConf, configProvider, false,
configProvider.getMetalakeName());
+ IcebergCatalogWrapperManager icebergCatalogWrapperManager;
Review Comment:
Makes sense, agreed. I'll replace the reflection with a factory lambda
(Function<..., IcebergCatalogWrapperManager>) so the constructor call is
checked at compile time. Will push the update shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
