FANNG1 commented on code in PR #11715:
URL: https://github.com/apache/gravitino/pull/11715#discussion_r3433912438


##########
catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java:
##########
@@ -813,6 +814,17 @@ public Integer calculateDatetimePrecision(String typeName, 
int columnSize, int s
       }
     }
 
+    // Handle datetime(N) format from SHOW CREATE TABLE
+    if (upperTypeName.startsWith("DATETIME(") && upperTypeName.endsWith(")")) {
+      try {
+        String precisionStr = upperTypeName.substring(9, 
upperTypeName.length() - 1);

Review Comment:
   Nit: please replace the hard-coded `9` with `"DATETIME(".length()` or a 
named constant so the substring boundary is self-documenting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to