roryqi commented on code in PR #11735:
URL: https://github.com/apache/gravitino/pull/11735#discussion_r3443698319
##########
bundles/aws/src/main/java/org/apache/gravitino/s3/credential/AwsIrsaCredentialGenerator.java:
##########
@@ -336,8 +298,8 @@ private String getValidatedRoleArn(String configRoleArn) {
return effectiveRoleArn;
}
- private Credentials assumeRoleWithSessionPolicy(
- String roleArn, String userName, String webIdentityToken, IamPolicy
sessionPolicy) {
+ private Credentials assumeRoleWithWebIdentity(
+ String roleArn, String userName, String webIdentityToken, @Nullable
IamPolicy sessionPolicy) {
Review Comment:
We can use optional to consider null value explictly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
