jiangxt2 commented on PR #11732:
URL: https://github.com/apache/gravitino/pull/11732#issuecomment-4775252892
Thanks for the review. After checking each comment against the actual PR
diff:
1. The code uses `createTableSql.replace('\, '\)` (the `char` overload), not
`replaceAll("\\n", " ")`. No regex engine is involved.
2. The variable is already named `fieldNames` in the PR — the typo from the
original code was fixed.
3. The `headerPattern` uses `([^`]+)` for the backtick-quoted branch, which
accepts any non-backtick character. The `\w+` branch only applies to unquoted
identifiers. Tests cover names like `p-2024_07` and `p-2024.08` inside
backticks.
4. The test does assert extracted partition names —
`listTransform.assignments()[0].name()` is checked against `"p1"`,
`"p-2024_07"`, `"p beijing", etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
