lasdf1234 commented on issue #11682: URL: https://github.com/apache/gravitino/issues/11682#issuecomment-4786384154
> Hi [@lasdf1234](https://github.com/lasdf1234), I've made a lot of progress on the login flow and features, but I had some important questions about the expectations of the flow. Currently, I have maybe 90% complete with a custom login page for basic auth, using a proper user and pw allows the user to access the data page, but I haven't properly resolved improper inputs yet. > > My main concerns were about how to handle the user returning to the login page by typing the url in. Since they are already logged in, should a feature that auto-redirects them back to the metadata page be implemented? Currently, if they go back to the login page and enter an improper User/Pw, they get 'logged out' in a sense. I'm unsure of how deep that really is, but they are forced to log back in to access metadata once more. > > Secondly, if a user is on the metadata page and reloads the page, the logout button disappears. I'm assuming it may have something to do with me removing the expiredIn timer for basicAuth, but since it appears during the first redirection, I feel it may be an issue for all authenticators? > > Now, some less important issues I noticed: > > * I noticed the constructor in factory.js didn't contain this.providerType = null for its standard initialization. initializeProvider() always handles that, but since configPromise and currentProvider are initialized to null here, I felt that it was missing. > * When running curl -s http://localhost:8090/configs, the JSON response does not include a trailing newline, so the shell prompt appears directly after the output. I'm not sure whether this is intentional or something that should be adjusted in ConfigServlet. @LauraXia123 Could you follow up on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
