zhoukangcn commented on PR #11731: URL: https://github.com/apache/gravitino/pull/11731#issuecomment-4828509692
Thanks for the work. A few concerns: **1. PR scope** +1275/-85 across 15 files — mixing INDEX syntax fix, AUTO_INCREMENT support, version detection, and multi-version Docker infra. Would be easier to review if split into 2-3 smaller PRs. **2. Backward compatibility** We should maintain backward compatibility with Doris 1.2.x until we explicitly announce dropping support in a future release. The new code unconditionally generates `USING INVERTED` for non-key indexes, but inverted index was not officially introduced until Doris 2.0.0 (per the [2.0.0 release notes](https://doris.apache.org/blog/release-note-2.0.0): "In Apache Doris 2.0.0, we introduced inverted index"). Although `IndexType.INVERTED` exists in the 1.2.x source code, we need to confirm whether the 1.2.x release packages actually include full support for it. The old `INDEX name (col)` without a USING clause worked fine on 1.2.x by defaulting to BITMAP. A version-aware branch (omit `USING` clause when Doris < 2.0) may be needed to avoid breaking existing deployments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
