jiangxt2 commented on PR #11807: URL: https://github.com/apache/gravitino/pull/11807#issuecomment-4841061889
Thanks for the suggestion! I've added `testAlterTableOnClusterSqlGeneration()` in `CatalogClickHouseClusterIT`. **What it verifies**: queries `system.query_log` after ALTER TABLE operations to confirm: - ALTER on a cluster table (ON_CLUSTER=true) → SQL contains `ON CLUSTER` clause ✅ - ALTER on a non-cluster table → SQL does NOT contain `ON CLUSTER` ✅ **Test result**: ``` CatalogClickHouseClusterIT > testAlterTableOnClusterSqlGeneration() PASSED (0.52s) Tests: 1 passed, 0 failed, 0 skipped ``` This differs from the existing `testAlterTableBranchCoverageInCluster` which validates ALTER functionality (add/modify columns etc.). The new test specifically proves the ON CLUSTER clause is injected into the executed SQL — something that cannot be verified through the Gravitino API alone, since single-node clusters succeed regardless of ON CLUSTER presence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
