roryqi opened a new pull request, #11843:
URL: https://github.com/apache/gravitino/pull/11843

   ### What changes were proposed in this pull request?
   
   This PR updates the config servlet to return 
`gravitino.authorization.serviceAdmins` as a list when it is exposed through 
`gravitino.server.visibleConfigs`.
   
   It also adds regression tests for:
   - a single configured service admin returned as a JSON array
   - `visibleConfigs` including service admins while the service admins value 
is not configured
   
   ### Why are the changes needed?
   
   When `gravitino.server.visibleConfigs=gravitino.authorization.serviceAdmins` 
is configured, `/configs` currently returns 
`gravitino.authorization.serviceAdmins` as a raw string for a single value. 
This is inconsistent with the typed config value and may break clients 
expecting an array.
   
   Fix: #11836
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. `/configs` now returns `gravitino.authorization.serviceAdmins` as a 
JSON array when it is exposed by `gravitino.server.visibleConfigs`.
   
   ### How was this patch tested?
   
   - `./gradlew :server:test --tests 
org.apache.gravitino.server.web.TestConfigServlet`
   - `git diff --check`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to