Copilot commented on code in PR #11847:
URL: https://github.com/apache/gravitino/pull/11847#discussion_r3504762562
##########
spark-connector/spark-common/src/main/java/org/apache/gravitino/spark/connector/jdbc/JdbcPropertiesConverter.java:
##########
@@ -46,8 +47,9 @@ public static JdbcPropertiesConverter getInstance() {
return JdbcPropertiesConverterHolder.INSTANCE;
}
- public static JdbcPropertiesConverter getPGInstance() {
- return JdbcPropertiesConverterHolder.PG_INSTANCE;
+ /** Returns the singleton instance that does not support table-level
properties. */
+ public static JdbcPropertiesConverter getNoTablePropertiesInstance() {
+ return JdbcPropertiesConverterHolder.NO_TABLE_PROPERTIES_INSTANCE;
}
Review Comment:
`JdbcPropertiesConverter.getPGInstance()` was removed and replaced with
`getNoTablePropertiesInstance()`. Since `getPGInstance()` was a `public` static
API, this is a binary/source breaking change for any downstream code using the
Spark connector internals. Consider keeping a deprecated compatibility shim
that delegates to the new method, so callers can migrate without an immediate
break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
