Copilot commented on code in PR #11849:
URL: https://github.com/apache/gravitino/pull/11849#discussion_r3505177617
##########
flink-connector/flink-common/src/test/java/org/apache/gravitino/flink/connector/integration/test/FlinkCommonIT.java:
##########
@@ -87,6 +87,23 @@ protected boolean supportGetSchemaWithoutCommentAndOption() {
protected abstract boolean supportDropCascade();
+ /**
+ * Returns {@code true} if the catalog supports schema CREATE/DROP via the
Gravitino API. Controls
+ * only the pure schema-lifecycle tests ({@code testCreateSchema}).
+ */
+ protected boolean supportsSchemaLifecycle() {
Review Comment:
supportsSchemaLifecycle() is introduced to allow subclasses to skip schema
lifecycle tests, but the base class still contains other schema tests (e.g.
schema comment/options and ALTER DATABASE tests) that CREATE/DROP schemas
without being gated by supportsSchemaLifecycle(). If a subclass overrides
supportsSchemaLifecycle() to false (as intended by this refactor), those
remaining tests will still run and likely fail when they attempt CREATE/DROP
via catalog.asSchemas(). Consider either (a) updating the relevant `@EnabledIf`
guards to also require supportsSchemaLifecycle(), or (b) making the existing
schema capability flags (supportSchemaOperationWithCommentAndOptions, etc.)
incorporate supportsSchemaLifecycle() by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
