jiangxt2 commented on code in PR #11884:
URL: https://github.com/apache/gravitino/pull/11884#discussion_r3517885596
##########
catalogs-contrib/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/converter/ClickHouseTypeConverter.java:
##########
@@ -76,7 +76,10 @@ public class ClickHouseTypeConverter extends
JdbcTypeConverter {
@Override
public Type toGravitino(JdbcTypeBean typeBean) {
- String typeName = TypeUtils.stripNullable(typeBean.getTypeName());
+ // ClickHouse allows LowCardinality wrapping Nullable:
LowCardinality(Nullable(String)).
+ // Nullable(LowCardinality(X)) is invalid in ClickHouse and not handled
here.
Review Comment:
ClickHouse only supports `LowCardinality(Nullable(X))`.
`Nullable(LowCardinality(X))` is invalid — the server rejects it with `Nested
type LowCardinality(String) cannot be inside Nullable type`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
