Copilot commented on code in PR #10785:
URL: https://github.com/apache/gravitino/pull/10785#discussion_r3535267130
##########
dev/docker/iceberg-rest-server/rewrite_config.py:
##########
@@ -41,6 +41,7 @@
"GRAVITINO_ICEBERG_REST_S3_ENDPOINT": "s3-endpoint",
"GRAVITINO_ICEBERG_REST_S3_REGION": "s3-region",
"GRAVITINO_ICEBERG_REST_S3_PATH_STYLE_ACCESS": "s3-path-style-access",
+ "GRAVITINO_ICEBERG_REST_S3_PROXY_ENDPOINT": "s3-proxy-endpoint",
"GRAVITINO_ICEBERG_REST_S3_ROLE_ARN": "s3-role-arn",
Review Comment:
This adds the new env var mapping for the standalone iceberg-rest-server
image, but the Gravitino server Docker env-var rewrite script doesn’t include
`GRAVITINO_ICEBERG_REST_S3_PROXY_ENDPOINT` yet (see
`dev/docker/gravitino/rewrite_gravitino_server_config.py`). If users run the
Iceberg REST service as an auxiliary service in the Gravitino server container,
this env var will be ignored. Please add the same mapping there (and update any
related server-config docs if needed) to keep env-var support consistent across
images.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
