laserninja commented on code in PR #11828:
URL: https://github.com/apache/gravitino/pull/11828#discussion_r3538824398
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergNamespaceOperations.java:
##########
@@ -83,13 +86,16 @@ public class IcebergNamespaceOperations {
private ObjectMapper icebergObjectMapper;
private IcebergNamespaceOperationDispatcher namespaceOperationDispatcher;
+ private IcebergViewOperationDispatcher viewOperationDispatcher;
@Context private HttpServletRequest httpRequest;
@Inject
public IcebergNamespaceOperations(
- IcebergNamespaceOperationDispatcher namespaceOperationDispatcher) {
+ IcebergNamespaceOperationDispatcher namespaceOperationDispatcher,
+ IcebergViewOperationDispatcher viewOperationDispatcher) {
this.namespaceOperationDispatcher = namespaceOperationDispatcher;
+ this.viewOperationDispatcher = viewOperationDispatcher;
Review Comment:
Done in ab29919 — `registerView` now follows the same rule as
`registerTable`: it is part of `IcebergNamespaceOperationDispatcher` (interface
+ executor + event dispatcher + hook dispatcher), and
`IcebergNamespaceOperations.registerView` calls
`namespaceOperationDispatcher.registerView(...)`. The view dispatcher no longer
handles register, and `IcebergNamespaceOperations` no longer injects
`IcebergViewOperationDispatcher`. Moved the import/owner/skip-if-exists hook
logic and its tests to `IcebergNamespaceHookDispatcher` accordingly. All
affected tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
