jiangxt2 commented on PR #11806: URL: https://github.com/apache/gravitino/pull/11806#issuecomment-4915486948
Re: `NumberUtils.isCreatable` suggestion on `resolveGranularity()`: Thanks for the suggestion! I looked into `NumberUtils.isCreatable` — it accepts hex (`0xFF`), decimals (`3.14`), scientific notation (`1.2e3`), and negative numbers, which are all invalid for granularity (must be a positive integer ≥ 1). So I think the current `Long.parseLong` + range check is more appropriate here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
